Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

only remove authenticated users access to ssh keys if they have permissions #1038

Merged
merged 3 commits into from
Jul 2, 2021

Conversation

bmc-msft
Copy link
Contributor

@bmc-msft bmc-msft commented Jul 2, 2021

No description provided.

@bmc-msft bmc-msft changed the title only remove authenticated users if they exist only remove authenticated users access to ssh keys if they have permissions Jul 2, 2021
.wait_with_output()
.await
.context("icalcs remove failed to run")?;
if !result.status.success() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to retry the operation? I am thinking we could be hitting some transient issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add this due to transient issue, but this prevents the failure that was induced by a different Azure VM extension that added an SSH key.

@bmc-msft bmc-msft merged commit 51ddaaa into microsoft:main Jul 2, 2021
@bmc-msft bmc-msft deleted the only-remove-system-if-exists branch July 2, 2021 17:45
@ghost ghost locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants