Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

delete secret on object delete #1085

Merged
merged 6 commits into from
Jul 21, 2021

Conversation

bmc-msft
Copy link
Contributor

As is, when we delete a notification, we don't delete the secrets saved in KeyVault.

This wires in the secrets being deleted upon deleting the parent object.

src/api-service/tests/test_secrets.py Show resolved Hide resolved
src/api-service/__app__/onefuzzlib/secrets.py Outdated Show resolved Hide resolved
src/api-service/__app__/onefuzzlib/orm.py Show resolved Hide resolved
@bmc-msft bmc-msft merged commit 3269dbb into microsoft:main Jul 21, 2021
@bmc-msft bmc-msft deleted the delete-secret-upon-object-delete branch July 21, 2021 20:04
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants