Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

use enum for local commands #1090

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

bmc-msft
Copy link
Contributor

As is, we use static strings for sub-command names. Moving to an enum means we can rely on the compiler to verify we've implemented everything correctly for the subcommands.

Copy link
Member

@ranweiler ranweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also consider migrating to structopt in the future, too. But that's a bigger change, and this is big improvement in the meantime.

@bmc-msft bmc-msft merged commit 77aaa5b into microsoft:main Jul 20, 2021
@bmc-msft bmc-msft deleted the use-enums-for-local-command-names branch July 20, 2021 16:14
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants