This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Use fallible callbacks for Mapping
placeholders
#1217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template expansion machinery allows
Mapping
placeholders which use a partial callback to provide an expansion value on demand. Add fallibility to the callback signature, which lets us avoid distinguish between callback errors and absent values. Update existingMapping
callbacks to return errors in some places where we currently map them toNone
.