Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Disable storageclient logs when setting admins #1304

Merged
merged 17 commits into from
Oct 1, 2021

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Sep 29, 2021

Summary of the Pull Request

When checking the existence of a table. The storageclient module logs an error message and throws an exception.
The exception is handled internally bu the message shows up in our deployment logs (see #1297).
This PR disables the logs for that module.

@chkeita chkeita changed the title Check if a table exists before applying the migration Disable storageclient logs when setting admins Sep 29, 2021
@chkeita chkeita marked this pull request as ready for review September 29, 2021 21:20
@chkeita chkeita requested a review from ranweiler September 29, 2021 21:28
src/deployment/deploy.py Outdated Show resolved Hide resolved
src/deployment/set_admins.py Outdated Show resolved Hide resolved
src/deployment/set_admins.py Outdated Show resolved Hide resolved
src/deployment/set_admins.py Outdated Show resolved Hide resolved
src/deployment/set_admins.py Show resolved Hide resolved
chkeita and others added 2 commits September 29, 2021 14:46
Co-authored-by: Joe Ranweiler <joe@lemma.co>
@chkeita chkeita enabled auto-merge (squash) October 1, 2021 18:03
@chkeita chkeita merged commit 3264ddd into microsoft:main Oct 1, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants