-
Notifications
You must be signed in to change notification settings - Fork 199
Fixing agent code. #1516
Fixing agent code. #1516
Conversation
Co-authored-by: Cheick Keita <kcheick@gmail.com>
Co-authored-by: Cheick Keita <kcheick@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What was the actual lint?
- Why did you change the program semantics, and why is that change okay / how did you test it?
@ranweiler i was the one that proposed the fix i tested it with string with and without ')' in it to see if it has the same behavior |
Lint errors linked above. It's not clear to
I added both errors to the original description |
@ranweiler & @chkeita - I was slowly working through some of the other clippy errors and I suddenly got this dump: This seems like it has a lot to do with coverage data? Is it appropriate to remove all of these unused fields? The last two have to do with 'large size difference between variants'? I can 'box' those, but I'm not sure if its correct for me to remove all those other fields. |
e6ac485
to
5c32ef2
Compare
Summary of the Pull Request
What is this about?
Fixing an agent code error related to clippy that occurs during the build.
Original errors:
PR Checklist
Info on Pull Request
What does this include?
Changes to lib.rs
Validation Steps Performed
Confirming build runs.