Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Resilient connection #153

Merged
merged 25 commits into from
Oct 28, 2020
Merged

Resilient connection #153

merged 25 commits into from
Oct 28, 2020

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Oct 14, 2020

Summary of the Pull Request

Using an exponential backoff strategy for the http calls in the agent.

PR Checklist

  • Applies to work item: supervisor connection to storage queue is not resilient  #79
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@chkeita chkeita marked this pull request as ready for review October 23, 2020 00:36
@chkeita chkeita changed the title [WIP] resilient connection Resilient connection Oct 23, 2020
src/agent/utils/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@bmc-msft bmc-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this is extremely positive change.

I didn't know defining traits for third-party structs was allowed. This is significantly better than the exponential backoff code added to AVML

src/agent/Cargo.toml Outdated Show resolved Hide resolved
src/agent/utils/src/lib.rs Outdated Show resolved Hide resolved
bmc-msft
bmc-msft previously approved these changes Oct 26, 2020
@bmc-msft bmc-msft dismissed their stale review October 26, 2020 22:51

Failures on CICD

@bmc-msft
Copy link
Contributor

Every task in testing is failing with

[
'task failed. exit_status:code=1 signal=None success=False', 
'', 
"[2020-10-26T22:43:50Z ERROR onefuzz_agent] error running task: Couldn't upload file.  path:/onefuzz/3f059c05-2b1b-44b9-985f-ae1c6135ad1b/task_inputs_2/eb408ddc4fa484e6befdf5954e56a2198c7a9fab dir:task_inputs_2 err:This request cannot be retried because it cannot be cloned\nError: Couldn't upload file.  path:/onefuzz/3f059c05-2b1b-44b9-985f-ae1c6135ad1b/task_inputs_2/eb408ddc4fa484e6befdf5954e56a2198c7a9fab dir:task_inputs_2 err:This request cannot be retried because it cannot be cloned\n"
]

@chkeita chkeita marked this pull request as draft October 27, 2020 02:12
@chkeita chkeita marked this pull request as ready for review October 27, 2020 05:04
src/agent/reqwest-retry/src/lib.rs Outdated Show resolved Hide resolved
@bmc-msft
Copy link
Contributor

Performing integration testing now

@bmc-msft bmc-msft merged commit db85341 into microsoft:main Oct 28, 2020
@chkeita chkeita deleted the chkeita/retry branch March 31, 2021 21:52
@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants