This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Add EventGrid compatible webhook format #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
reviewed
Feb 5, 2022
chkeita
approved these changes
Feb 5, 2022
|
We should update the doc. https://github.com/microsoft/onefuzz/blob/main/docs/webhook_events.md |
stishkin
force-pushed
the
event-grid-compatible-webhooks
branch
from
16f6634 to
d3ae874
Compare
mgreisen
approved these changes
Feb 11, 2022
chkeita
pushed a commit
that referenced
this pull request
Feb 15, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to have webhooks posted in Azure Event Grid compatible format
Currently OneFuzz webhook data layout is not compatible with Azure Event Grid. Event Grid expects an array of objects and also the fields are named differently from Event Grid schema.
This a non-breaking change that adds an optional
--message_formatparameter to CLI to allow selection of existing OneFuzz webhook format or Event Grid friendly format. If not specified, then default is existing OneFuzz format.This change makes webhooks more "Azure friendly".