This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Fail fast if managed task workers are near-OOM #1657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranweiler
changed the title
Memory watchdog
Fail fast if managed task workers are near-OOM
Feb 15, 2022
ranweiler
commented
Feb 15, 2022
ranweiler
commented
Feb 15, 2022
ranweiler
commented
Feb 15, 2022
stishkin
approved these changes
Feb 16, 2022
mgreisen
approved these changes
Feb 16, 2022
chkeita
reviewed
Feb 16, 2022
chkeita
reviewed
Feb 16, 2022
chkeita
approved these changes
Feb 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
onefuzz::memory::available_bytes()
to enable checking system-wide memory usageTesting
/proc/meminfo
on Linuxmemory
example binary inonefuzz
crateonefuzz-agent
functionally tested by forcing external on-VM OOMTested on Windows by using
notmyfault
from SysInternals to leak from the paged memory pool, on a node where a healthy task was in therunning
state. On Linux, disabled OOM-killer, set overcommit to always-allow, and ran small custom program that rapidly leaks heap memory. Checked for task failure, with the reason matching the new error message, as well as telemetry.Closes #1633.