Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Delete nodes when they're done #1763

Merged
merged 12 commits into from
Apr 12, 2022

Conversation

tevoinea
Copy link
Member

@tevoinea tevoinea commented Apr 7, 2022

Summary of the Pull Request

What is this about?

In order to maintain a consistent VMSS instance model, we're opting to delete nodes once they complete their work. Newly created nodes will have the latest model which will hopefully fix the issue.

This change opts to delete nodes instead of reimaging them when they are complete.

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@tevoinea tevoinea enabled auto-merge (squash) April 12, 2022 15:15
@tevoinea tevoinea disabled auto-merge April 12, 2022 16:38
@tevoinea tevoinea enabled auto-merge (squash) April 12, 2022 16:39
@tevoinea tevoinea merged commit 87eb606 into microsoft:main Apr 12, 2022
AdamL-Microsoft pushed a commit that referenced this pull request Apr 18, 2022
* Delete nodes when they're done

* Missed a file

* Load node disposal strategy from env var

* Lint

* Fix subtle bug

* Deleting doesn't work, will 'decomission' nodes once they complete work

* Missed a file

* Remove logging line
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants