This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Updating deploy.py for dotnet deployments #1752 #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
reviewed
Apr 22, 2022
chkeita
reviewed
Apr 22, 2022
chkeita
approved these changes
Apr 25, 2022
…ly by moving app settings into a separate template
raghavthind2005
approved these changes
Apr 30, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adding flag and function for '--dotnet_deploy' to deploy.py to specify deploying the dotnet version of the services along with the python ones, with the default (e.g. no --dotnet_deploy flag) still being to only deploy the python versions.
Also something recently changed on the backend of Azure creating a possible race condition for our function app deployments when using bicep templates. In order for the deployment to work and pass all of the application settings to both the python and dotnet function apps at deployment time, we had to reconfigure the .bicep templates to order the app settings to be setup after both of the function apps have already been deployed.
PR Checklist
Info on Pull Request
Updated:
src/deployment/deploy.py
src/deployment/azuredeploy.bicep
src/deployment/bicep-templates/function.bicep
Added:
src/deployment/bicep-templates/function-settings.bicep