This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Upgrade to latest stable notify preview
#1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranweiler
commented
Apr 26, 2022
ranweiler
commented
Apr 26, 2022
ranweiler
commented
Apr 26, 2022
chkeita
approved these changes
Apr 26, 2022
tevoinea
approved these changes
Apr 27, 2022
ranweiler
commented
Apr 27, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
notifyto its latest stable preview release5.0.0-pre.14.The latest
notifyrelease oncrates.iois4.0.17. The 4.x series receives very occasional backports (the last one was a year ago), but it is not actively developed, and acargo auditrun uncovers many issues that are unlikely to be addressed. This upgrade lets us avoid problematic transitive dependencies, and align our direct dependency onnotifyto its actively-maintained major version.By upgrading to the most-stable 5.x preview version, we also get to use the new
WatcherAPI. This accepts any implementer of the newEventHandlertrait, which includes closures. This lets us directly send (fallible) watcher events via the synchronousUnboundedSender::send()method, instead of having to shim the syncSenderfrom the 4.x API with a background async task.This PR also changes the
DirectoryMonitorpublic API such thatstart()is async. This enables replacing a private use of the blockingstd::fs::canonicalize()function. It also makesnext_file()fallible, which reflects the fallibility of internal filesystem watch eventing. Finally, it adds unit tests and an example binary.Closes #1083.