Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix Nullable Node Heartbeat Param. #1854

Merged
merged 11 commits into from
Apr 28, 2022
Merged

Fix Nullable Node Heartbeat Param. #1854

merged 11 commits into from
Apr 28, 2022

Conversation

nharper285
Copy link
Contributor

Summary of the Pull Request

What is this about?
New nodes were triggering NodeHeartbeat failures because the hearbeat was null.

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@nharper285 nharper285 merged commit 4aa8058 into microsoft:main Apr 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stishkin stishkin stishkin approved these changes

@chkeita chkeita chkeita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nharper285 @chkeita @stishkin