This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Add scripts to install dotnet on windows and ubuntu #2038
Merged
tevoinea
merged 7 commits into
microsoft:main
from
tevoinea:tevoinea/AddDotnetToolsToVm
Jun 14, 2022
Merged
Add scripts to install dotnet on windows and ubuntu #2038
tevoinea
merged 7 commits into
microsoft:main
from
tevoinea:tevoinea/AddDotnetToolsToVm
Jun 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
reviewed
Jun 10, 2022
chkeita
reviewed
Jun 10, 2022
chkeita
reviewed
Jun 10, 2022
chkeita
approved these changes
Jun 13, 2022
Porges
reviewed
Jun 13, 2022
Porges
reviewed
Jun 13, 2022
Porges
reviewed
Jun 13, 2022
ranweiler
reviewed
Jun 13, 2022
ghost
locked as resolved and limited conversation to collaborators
Jul 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
This PR adds scripts to install dotnet and related tooling on ubuntu and windows.
PR Checklist
dotnet
and tools on VMs #2005Info on Pull Request
What does this include?
These scripts were written with the following goals:
I made the tradeoff by setting the
DOTNET_ROOT
environment variable/adding /etc/dotnet/install_location on linux in order to make it easier to call the dotnet tools from the agent.The alternative approach is that every time we call the dotnet tools from the agent, we must set the DOTNET_ROOT env var for that process every time.
I'm open to both approaches, the reason I chose the current implementation is because there's no way to indicate on the agent that the env var is required so it's easy to make mistakes.
Validation Steps Performed
How does someone test & validate?