Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Add scripts to install dotnet on windows and ubuntu #2038

Merged
merged 7 commits into from
Jun 14, 2022

Conversation

tevoinea
Copy link
Member

Summary of the Pull Request

What is this about?

This PR adds scripts to install dotnet and related tooling on ubuntu and windows.

PR Checklist

Info on Pull Request

What does this include?

These scripts were written with the following goals:

  • A small footprint regarding system configuration (environment variables, files in 'standard' locations)
  • Ease of use by the agent

I made the tradeoff by setting the DOTNET_ROOT environment variable/adding /etc/dotnet/install_location on linux in order to make it easier to call the dotnet tools from the agent.

The alternative approach is that every time we call the dotnet tools from the agent, we must set the DOTNET_ROOT env var for that process every time.

I'm open to both approaches, the reason I chose the current implementation is because there's no way to indicate on the agent that the env var is required so it's easy to make mistakes.

Validation Steps Performed

How does someone test & validate?

  • I spun up a fresh ubuntu docker image and ran the script
  • I spun up a fresh Win10 VM and ran the script

@tevoinea tevoinea requested review from chkeita and ranweiler June 13, 2022 19:59
src/runtime-tools/linux/setup.sh Outdated Show resolved Hide resolved
src/runtime-tools/win64/onefuzz.ps1 Outdated Show resolved Hide resolved
src/runtime-tools/win64/onefuzz.ps1 Outdated Show resolved Hide resolved
@tevoinea tevoinea enabled auto-merge (squash) June 14, 2022 14:22
@tevoinea tevoinea merged commit dec4285 into microsoft:main Jun 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install dotnet and tools on VMs
4 participants