This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Implement the containers function for C#
#2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
force-pushed
the
function/containers
branch
from
f181c05 to
5243738
Compare
Porges
force-pushed
the
function/containers
branch
from
d3e39c7 to
18c92cf
Compare
tevoinea
approved these changes
Jun 23, 2022
stishkin
reviewed
Jun 27, 2022
stishkin
reviewed
Jun 27, 2022
stishkin
approved these changes
Jun 27, 2022
Porges
force-pushed
the
function/containers
branch
2 times, most recently
from
70eea31 to
083db3d
Compare
Porges
force-pushed
the
function/containers
branch
2 times, most recently
from
18969a6 to
61b5bb7
Compare
Porges
force-pushed
the
function/containers
branch
from
61b5bb7 to
43a5111
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fairly straightforward but required implementation of a few more functions on the
IContainers/Containersclass.PR Checklist
containersfunction to C# #2077Requires documentation to be updatedI've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx