-
Notifications
You must be signed in to change notification settings - Fork 199
Reuse Agent artifacts if nothing in src/agent changes #2115
Conversation
e621a2b
to
12f129b
Compare
We should probably build the Rust version into the cache key for both this and the pre-reqs. |
If I remember correctly, the check-pr pipeline pulls down the github actions artifacts when testing against a PR. We should make sure this doesn't break that flow. I do see artifacts published at the end of the actions run so it might 'just work'. |
Yes, the artifacts are still downloaded and packaged into the release zip, so it should work the same as before. |
12f129b
to
4cfd94d
Compare
This is done now. |
167e555
to
6710de7
Compare
Running one more |
One thing to think about is that the version number in the compiled binary might be wrong. Need to disable this cache on builds from a specific tag. |
This is done now. |
b3d9bd6
to
65c5b69
Compare
Cleanly passed |
Hold off on merging as I think we still have a problem with the version check in the API service, which will try to reimage the nodes if they don't have an exact version match. |
We now set |
9b8cdcc
to
5e5807d
Compare
5e5807d
to
c37c089
Compare
The agent build takes most of the CI runtime, so improve it by only rebuilding if the pre-reqs or something inside
src/agent
changes.