Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix execution of TimerProxy #2133

Merged
merged 8 commits into from
Jul 7, 2022
Merged

Fix execution of TimerProxy #2133

merged 8 commits into from
Jul 7, 2022

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Jul 6, 2022

Summary of the Pull Request

  • fixed behavior of Container.SaveBlob (file was not being overwritten)
  • added support for default value in the entity converter
  • fix scaleset size data type
  • added initialization of Subnet
  • renamed TestHook Info to _Info to prevent clashing of name function name
  • added target framework to ApiServiceProject to help local debugging

- fixed behavior of Container.SaveBlob (file was not being overwritten)
- added support for default value in the entity converter
- fix scaleset size data type
- added initialization of Subnet
- renamed TestHook Info to _Info to prevent clashing of name function mame
- added target framework to ApiServiceProject to help local debugging
@chkeita chkeita requested review from Porges, stishkin and tevoinea and removed request for Porges July 6, 2022 23:24
Copy link
Member

@tevoinea tevoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised to learn there's no C# equivalent for https://doc.rust-lang.org/std/default/trait.Default.html

src/ApiService/ApiService/OneFuzzTypes/Model.cs Outdated Show resolved Hide resolved
@chkeita chkeita enabled auto-merge (squash) July 7, 2022 15:28
@chkeita chkeita disabled auto-merge July 7, 2022 15:50
@chkeita chkeita merged commit aa2e76e into microsoft:main Jul 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants