Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Add multi-var target spec, improve errors #2136

Merged
merged 11 commits into from
Jul 7, 2022
Merged

Add multi-var target spec, improve errors #2136

merged 11 commits into from
Jul 7, 2022

Conversation

ranweiler
Copy link
Member

Summary

Users can now specify a libfuzzer-dotnet target via specifying either:

  1. LIBFUZZER_DOTNET_TARGET as <assembly>:<class>:<method>

or all of:

  1. LIBFUZZER_DOTNET_TARGET_ASSEMBLY
  2. LIBFUZZER_DOTNET_TARGET_CLASS
  3. LIBFUZZER_DOTNET_TARGET_METHOD

Closes #2130.

Changes

  • Introduce the new LibFuzzerDotnetTarget class to encapsulate specification of a libfuzzer-dotnet target
  • Hang static environment lookup methods on new class
  • Add multiple-env var lookup option, and fall back on it if a :-delimited shorthand var is unset
  • Factor env lookup logic out of the main program

@ranweiler ranweiler requested review from Porges and chkeita July 6, 2022 22:35
@ranweiler ranweiler requested a review from chkeita July 6, 2022 23:20
Porges
Porges reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@Porges Porges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggested changes

@ranweiler ranweiler force-pushed the dotnet-loader-env-vars branch from 0ebd44c to b4cff9d Compare July 7, 2022 17:20
@ranweiler ranweiler merged commit edf5371 into microsoft:main Jul 7, 2022
@ranweiler ranweiler deleted the dotnet-loader-env-vars branch July 7, 2022 18:20
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Porges Porges Porges left review comments

@tevoinea tevoinea tevoinea approved these changes

@chkeita chkeita chkeita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve LibFuzzerDotnetLoader env var ergonomics
4 participants
@ranweiler @Porges @chkeita @tevoinea