Migrating notifications #2188

chkeita · 2022-07-25T16:33:47Z

Summary of the Pull Request

What is this about?

Applies to work item: #xxx
CLA signed. If not, go over here and sign the CLI.
Tests added/passed
Requires documentation to be updated
I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

What does this include?

How does someone test & validate?

refactor secretdata finish transfering Notifiction objects

chkeita added 9 commits July 25, 2022 09:33

Migrating notification

8bc89b4

add dotnet enpoint setting in the config

217d196

Merge branch 'main' into rewrite

7041469

format

6f25296

fix unit test

b9e0a55

format

de92567

build fix

4d3cc4e

fix notifictions function definition

ae3cfc7

Merge branch 'main' into rewrite

2bf3a02

chkeita marked this pull request as ready for review July 25, 2022 23:34

chkeita requested review from Porges, tevoinea and stishkin and removed request for Porges, tevoinea and stishkin July 25, 2022 23:34

chkeita changed the title ~~Migrating notification~~ Migrating notifications Jul 27, 2022

stishkin approved these changes Jul 27, 2022

View reviewed changes

Merge branch 'main' into rewrite

e4ba2d0

chkeita marked this pull request as draft July 27, 2022 19:47

chkeita added 2 commits July 27, 2022 16:58

fix deserilization of requests

ff8753d

refactor secretdata finish transfering Notifiction objects

format

4662058

chkeita marked this pull request as ready for review July 28, 2022 00:01

chkeita merged commit 25242f1 into microsoft:main Jul 28, 2022

chkeita mentioned this pull request Jul 29, 2022

Migrate notifications #2187

Closed

chkeita linked an issue Jul 29, 2022 that may be closed by this pull request

Migrate notifications #2187

Closed

ghost locked as resolved and limited conversation to collaborators Aug 27, 2022