Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Use absolute path for command replacements #22

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Use absolute path for command replacements #22

merged 3 commits into from
Sep 22, 2020

Conversation

tunz
Copy link
Contributor

@tunz tunz commented Sep 22, 2020

Summary of the Pull Request

Onefuzz will replace command replacement values such as {input} to absolute paths instead of relative path.

PR Checklist

  • Applies to work item: Full path of the input file #18
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

this will get canonicalized paths when they are evaluated. @bmc-msft this is what I described. This also handles the case that target_options has {input} well.

Validation Steps Performed

Updated test_expand testcase.

@bmc-msft bmc-msft merged commit e120550 into microsoft:main Sep 22, 2020
@bmc-msft bmc-msft linked an issue Sep 22, 2020 that may be closed by this pull request
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full path of the input file
2 participants