This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Port auto scale scaleset shutdown bug fix to csharp #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/tevoinea/onefuzz into tevoinea/PortAutoScaleBugFixToCsharp
chkeita
approved these changes
Aug 17, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Ports the python code from #2232 to C#.
PR Checklist
Info on Pull Request
What does this include?
Microsoft.Azure.ManagementtoAzure.ResourceManagersince the new one is the recommended path forward.Errortype directly.Shutdownstate forScaleset(includes most of the logic from Adjust auto scale to scale down nodes on shutdown #2232ListVmssValidation Steps Performed
How does someone test & validate?
Once the rest of
TimerWorkersis ported, we can validate the expected scaleset behavior.Footnotes
https://www.nuget.org/packages/Microsoft.Azure.Management.ResourceManager/3.17.4-preview ↩