Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix NullReferenceException in CreateQueue #2283

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Fix NullReferenceException in CreateQueue #2283

merged 1 commit into from
Aug 22, 2022

Conversation

Porges
Copy link
Member

@Porges Porges commented Aug 22, 2022 •
edited
Loading

CreateIfNotExistsAsync is documented as returning null if the queue already exists:

        // Returns:
        //     If the queue does not already exist, a Azure.Response describing the newly created
        //     queue. If the queue already exists, null.

To be investigated: why did we not hit this earlier? Why did null reference checking not trigger here?

@Porges Porges enabled auto-merge (squash) August 22, 2022 22:21
@Porges Porges force-pushed the fix/null-ref-createqueue branch from 6ebb922 to 6194884 Compare August 22, 2022 22:49
@Porges Porges merged commit 21a4231 into main Aug 22, 2022
@Porges Porges deleted the fix/null-ref-createqueue branch August 23, 2022 00:27
@ghost ghost locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stishkin stishkin stishkin approved these changes

@ranweiler ranweiler ranweiler approved these changes

@chkeita chkeita chkeita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Porges @chkeita @ranweiler @stishkin