Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Changing CLI Scaleset size parameter to max_size. #2293

Merged
merged 16 commits into from
Aug 26, 2022

Conversation

nharper285
Copy link
Contributor

@nharper285 nharper285 commented Aug 24, 2022

Summary of the Pull Request

What is this about?
Updating the scaleset size parameter to be called max_size and set the initial size of the scaleset to be min_instances - aka 0. This means that the scaleset wont' be initialized with it's max number of nodes and instead grow to meet demand.

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

Closes #2227

@nharper285 nharper285 marked this pull request as ready for review August 24, 2022 23:13
Copy link
Member

@tevoinea tevoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this comment, can't figure out how to deleted it

src/cli/onefuzz/api.py Outdated Show resolved Hide resolved
src/cli/onefuzz/api.py Outdated Show resolved Hide resolved
@nharper285 nharper285 merged commit dcb706f into microsoft:main Aug 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Scaleset Scaling Params - Change Size to MaxSize
3 participants