Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Rework use of storage clients #2302

Merged
merged 10 commits into from
Sep 6, 2022
Merged

Rework use of storage clients #2302

merged 10 commits into from
Sep 6, 2022

Conversation

Porges
Copy link
Member

@Porges Porges commented Aug 26, 2022


Abandoned changes:

  • Use managed identity to access storage accounts instead of using shared key — no longer need to use management client to fetch shared keys.
    • This should improve overall performance since we don't need to fetch the keys.
    • As an exception to this, the queue client needs shared keys to generate SAS URIs.

This was abandoned since:

  • we still need shared-key access for Queue SAS generation, so we can't remove shared-key access
  • our current MSI token is not authorized for direct access to storage so we would need to add more roles to the deployment

@Porges Porges changed the title Rework storage clients Rework use of storage clients Aug 26, 2022
@Porges Porges force-pushed the queries-rework branch 6 times, most recently from 803e845 to 1d992f5 Compare August 31, 2022 23:19
@Porges Porges marked this pull request as ready for review August 31, 2022 23:19
@Porges Porges enabled auto-merge (squash) September 6, 2022 21:41
@Porges Porges merged commit 84b2cc9 into main Sep 6, 2022
@Porges Porges deleted the queries-rework branch September 7, 2022 00:36
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants