This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Provide the ability to create a new cli application registration #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
commented
Oct 29, 2020
src/deployment/registration.py
Outdated
Comment on lines
436
to
445
|
|
||
| # todo: update the internal docs (https://dev.azure.com/msresearch/OneFuzz/_git/OneFuzz?path=%2FREADME.md&_a=preview&version=GBinternal-information) with | ||
|
|
||
| # Mandatory role assigment | ||
| # if your org require that you prevent guest access by requiring a role assigment. | ||
| # The default CLI will not be able to access the service. | ||
| # you will need to create a new cli registration by executing the following | ||
| # ``` | ||
| # python registration.py create_cli_registration INSTANCENAME [--registration_name REGISTRATIONNAME] | ||
| # ``` |
There was a problem hiding this comment.
self reminder to update the documentation before the merge
There was a problem hiding this comment.
will update the docs once this PR is approved
https://dev.azure.com/msresearch/OneFuzz/_git/OneFuzz?path=%2FREADME.md&version=GBinternal-information
Guest account access
If you need prevent guest access by requiring a role assigment, the default CLI will not be able to access the service.
You will need to create a new cli registration by executing the following.
python registration.py create_cli_registration INSTANCENAME [--registration_name REGISTRATIONNAME]
Then use the provided credentials in your onefuzz config
onefuzz config --client_id CLIENTID
|
Performing integration tests |
bmc-msft
suggested changes
Oct 30, 2020
There was a problem hiding this comment.
Currently fails due to:
running deployment
Traceback (most recent call last):
File "deploy.py", line 63, in <module>
from registration import (
ImportError: cannot import name 'update_pool_registration' from 'registration' (/tmp/tmpitt7aqre/registration.py)
Resource group 'pr-check-3ff769f69f004a0780e6d3a3cbc7253c' could not be found.
Traceback (most recent call last):
File "/home/bcaswell/projects/onefuzz/tools/check-pr", line 254, in <module>
main()
File "/home/bcaswell/projects/onefuzz/tools/check-pr", line 247, in main
d.run(merge_on_success=args.merge_on_success)
File "/home/bcaswell/projects/onefuzz/tools/check-pr", line 217, in run
self.deploy(dist)
File "/home/bcaswell/projects/onefuzz/tools/check-pr", line 168, in deploy
subprocess.check_call(cmd, shell=True)
File "/usr/lib/python3.8/subprocess.py", line 364, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command './deploy-venv/bin/python deploy.py uksouth pr-check-3ff769f69f004a0780e6d3a3cbc7253c pr-check-3ff769f69f004a0780e6d3a3cbc7253c cicd' returned non-zero exit status 1.
|
Integration testing in progress (currently waiting on fresh build) |
bmc-msft
approved these changes
Nov 2, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?