This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Do not fail task on notification failure #2435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Closes #2422, today if we fail to process a notification queue message more than 5 times, the message ends up in a poison queue. But, we also fail the task associated with that notification and we don't want that behavior.
PR Checklist
Info on Pull Request
What does this include?
fail_task
tolog_failed_notifications
log_failed_notifications
no longer fails the tasklog_failed_notifications
includes the notification id in the error message for better debuggingteams
webhook failure also includes the notification idqueue_file_changes
message, we calllog_failed_notifications
before moving the message to the poison queueRelated but not included in this PR: #2436
Validation Steps Performed
How does someone test & validate?