Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

do not discard proxy objects when setting state #2441

Merged
merged 1 commit into from
Sep 23, 2022
Merged

do not discard proxy objects when setting state #2441

merged 1 commit into from
Sep 23, 2022

Conversation

stishkin
Copy link
Contributor

No description provided.

@stishkin stishkin requested review from Porges and tevoinea September 22, 2022 21:29
@stishkin stishkin changed the title do not loose proxy objects when setting state do not discard proxy objects when setting state Sep 22, 2022
@Porges Porges force-pushed the timer-proxy-bug-fix branch from ef81612 to 2ec76c4 Compare September 22, 2022 23:28
@Porges Porges enabled auto-merge (squash) September 22, 2022 23:28
@Porges Porges mentioned this pull request Sep 23, 2022
Merged
@Porges Porges merged commit dc2c464 into main Sep 23, 2022
@Porges Porges deleted the timer-proxy-bug-fix branch September 23, 2022 01:29
Porges added a commit that referenced this pull request Sep 26, 2022
@Porges
Add Roslyn analyzer to check results are used (#2443)
5ee4cd0 
As seen in #2441, it is easy to drop return values of updated entities accidentally.

This PR adds a Roslyn Analyzer which will detect when return values are unused. To explicitly ignore a value you can drop it with `_ = …;`

Closes #2442.
@ghost ghost locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Porges Porges Porges approved these changes

@tevoinea tevoinea Awaiting requested review from tevoinea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stishkin @Porges