Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

add instance_id generated at install time #245

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

bmc-msft
Copy link
Contributor

@bmc-msft bmc-msft commented Nov 2, 2020

Summary of the Pull Request

Adds a randomly generated UUID that is unique to each install that is included in telemetry.

PR Checklist

  • Applies to work item: Add a unique per-install GUID to telemetry #234
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

This adds an instance_id that is generated at install time, and add it to the supervisor and agent configs to be used if telemetry is enabled.

NOTE: Including a per-install randomly generated UUID as an instance ID was approved during the initial internal privacy review.

Validation Steps Performed

Standard integration tests

@bmc-msft bmc-msft requested a review from ranweiler November 2, 2020 18:48
@bmc-msft bmc-msft merged commit 6c59877 into microsoft:main Nov 2, 2020
@bmc-msft bmc-msft deleted the add-instance-id branch November 2, 2020 19:27
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants