Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

C#: Correct pool transitions #2462

Merged
merged 1 commit into from
Sep 29, 2022
Merged

C#: Correct pool transitions #2462

merged 1 commit into from
Sep 29, 2022

Conversation

Porges
Copy link
Member

@Porges Porges commented Sep 29, 2022

ScalesetOperations.SearchByPool and NodeOperations.SearchByPoolName will never return null. Instead, fetch the results into lists and check if they are empty or not.

@Porges Porges requested a review from stishkin September 29, 2022 03:09
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #2462 (53a425a) into main (0e2f651) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2462   +/-   ##
=======================================
  Coverage   29.88%   29.89%           
=======================================
  Files         288      288           
  Lines       35185    35175   -10     
=======================================
  Hits        10516    10516           
+ Misses      24669    24659   -10     
Impacted Files Coverage Δ
...ApiService/ApiService/onefuzzlib/PoolOperations.cs 39.56% <0.00%> (+2.65%) ⬆️
...rc/ApiService/ApiService/onefuzzlib/ShrinkQueue.cs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Porges Porges force-pushed the correct-pool-transitions branch from 1c4b111 to 53a425a Compare September 29, 2022 03:19
@Porges Porges merged commit 8f4cf9d into main Sep 29, 2022
@Porges Porges deleted the correct-pool-transitions branch September 29, 2022 04:10
@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants