Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

CLI: Retry on connection reset #2468

Merged
merged 5 commits into from
Sep 29, 2022
Merged

CLI: Retry on connection reset #2468

merged 5 commits into from
Sep 29, 2022

Conversation

Porges
Copy link
Member

@Porges Porges commented Sep 29, 2022

In our integration test run we are seeing some connection-reset errors which causes the CLI operation to fail.

To fix this:

  1. Set TCP-KeepAlive to keep Azure load balancer connections alive longer than the default timeout (4 minutes).
  2. Treat ConnectionResetError as retryable.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #2468 (d4d19a6) into main (0c4cd54) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2468      +/-   ##
==========================================
+ Coverage   29.88%   30.03%   +0.14%     
==========================================
  Files         288      288              
  Lines       35180    35324     +144     
==========================================
+ Hits        10513    10609      +96     
- Misses      24667    24715      +48     
Impacted Files Coverage Δ
src/ApiService/ApiService/onefuzzlib/Config.cs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/tasks/merge/generic.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/tasks/fuzz/generator.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/tasks/report/generic.rs 0.00% <0.00%> (ø)
...rc/agent/onefuzz-task/src/tasks/coverage/dotnet.rs 0.00% <0.00%> (ø)
...rc/agent/onefuzz-task/src/tasks/fuzz/supervisor.rs 0.00% <0.00%> (ø)
...c/agent/onefuzz-task/src/tasks/analysis/generic.rs 0.00% <0.00%> (ø)
...c/agent/onefuzz-task/src/tasks/coverage/generic.rs 0.00% <0.00%> (ø)
...agent/onefuzz-task/src/tasks/regression/generic.rs 0.00% <0.00%> (ø)
...ent/onefuzz-task/src/tasks/regression/libfuzzer.rs 0.00% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Porges Porges force-pushed the retry-on-connection-reset branch from d4d19a6 to 8173e12 Compare September 29, 2022 21:06
@Porges
Copy link
Member Author

Porges commented Sep 29, 2022

Doing a check-pr run first to validate.

@Porges
Copy link
Member Author

Porges commented Sep 29, 2022

Didn't cause any problems, at least.

@Porges Porges merged commit 4c5023c into main Sep 29, 2022
@Porges Porges deleted the retry-on-connection-reset branch September 29, 2022 22:23
@ghost ghost locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants