This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Only fetch VM InstanceView data when required #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
force-pushed
the
instanceview-only-when-needed
branch
from
5255e0f to
b165fd8
Compare
chkeita
approved these changes
Oct 11, 2022
|
Validating with |
Codecov Report
@@ Coverage Diff @@
## main #2506 +/- ##
==========================================
- Coverage 29.99% 29.97% -0.02%
==========================================
Files 289 289
Lines 35391 35409 +18
==========================================
Hits 10615 10615
- Misses 24776 24794 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Had some problems with the run but I don't believe they are due to this change. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching the
InstanceViewdata for a VM is considered a “high-cost” operation by VMSS and contributes to throttling. In most cases we do not need this data, so split theGetVmmethod into two versions, one that fetches theInstanceViewdata and one that doesn’t.We only need
InstanceViewdata during VM provisioning failures, to see what went wrong.