Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Handle nulls better in scaleset shutdown #2538

Merged
merged 5 commits into from
Oct 20, 2022

Conversation

tevoinea
Copy link
Member

Summary of the Pull Request

What is this about?

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #2538 (635afe8) into main (f313a37) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2538      +/-   ##
==========================================
- Coverage   29.84%   29.84%   -0.01%     
==========================================
  Files         288      288              
  Lines       35677    35680       +3     
==========================================
  Hits        10648    10648              
- Misses      25029    25032       +3     
Impacted Files Coverage Δ
...ervice/ApiService/onefuzzlib/ScalesetOperations.cs 2.66% <0.00%> (-0.01%) ⬇️
...ApiService/ApiService/onefuzzlib/VmssOperations.cs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tevoinea tevoinea enabled auto-merge (squash) October 20, 2022 23:38
@tevoinea tevoinea merged commit 66dc7f5 into microsoft:main Oct 20, 2022
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Oct 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants