Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Downgrade instance not found exception #2549

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Downgrade instance not found exception #2549

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8cd423
Don't log exception when node no longer exists in azure
Oct 21, 2022
8d13cd5
fmt
Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ApiService/ApiService/onefuzzlib/VmssOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,8 @@ public async Async.Task<OneFuzzResultVoid> UpdateScaleInProtection(Scaleset scal
return OneFuzzResultVoid.Ok;
} catch (RequestFailedException ex) when (ex.Status == 409 && ex.Message.StartsWith("The request failed due to conflict with a concurrent request")) {
return OneFuzzResultVoid.Error(ErrorCode.UNABLE_TO_UPDATE, $"protection policy update is already in progress: {vmId}:{instanceId} in vmss {scaleset.ScalesetId}");
} catch (RequestFailedException ex) when (ex.Status == 400 && ex.Message.Contains("The provided instanceId") && ex.Message.Contains("not an active Virtual Machine Scale Set VM instanceId.")) {
chkeita marked this conversation as resolved.
Show resolved Hide resolved
return OneFuzzResultVoid.Error(ErrorCode.UNABLE_TO_UPDATE, $"The node with instanceId {instanceId} no longer exists in scaleset {scaleset.ScalesetId}");
} catch (Exception ex) {
_log.Exception(ex, $"unable to set protection policy on: {vmId:Tag:MachineId}:{instanceId:Tag:InstanceId} in vmss {scaleset.ScalesetId:Tag:ScalesetId}");
return OneFuzzResultVoid.Error(ErrorCode.UNABLE_TO_UPDATE, $"unable to set protection policy on: {vmId}:{instanceId} in vmss {scaleset.ScalesetId}");
Expand Down