Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Improve webhook logging and accept more HTTP success codes #2568

Conversation

tevoinea
Copy link
Member

Summary of the Pull Request

What is this about?

Webhooks are being successfully sent but onefuzz is interpreting them as failures. This PR improves logging when there's a failure and also accepts a wider variety of HTTP codes as successful.

Info on Pull Request

What does this include?

  • Accept all HTTP codes 200-299 as success
  • Log request details on unsuccessful requests to improve debuggability
  • NOTE: Exceptions are already handled and logged in a parent function

@codecov-commenter
Copy link

Codecov Report

Merging #2568 (9ee62c4) into main (c086f24) will increase coverage by 2.68%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2568      +/-   ##
==========================================
+ Coverage   29.83%   32.52%   +2.68%     
==========================================
  Files         289      162     -127     
  Lines       35752    21674   -14078     
==========================================
- Hits        10666     7049    -3617     
+ Misses      25086    14625   -10461     
Impacted Files Coverage Δ
src/agent/onefuzz/src/env.rs 0.00% <0.00%> (-83.34%) ⬇️
src/agent/onefuzz/src/libfuzzer.rs 12.23% <0.00%> (-57.87%) ⬇️
src/agent/onefuzz/src/memory.rs 0.00% <0.00%> (-25.00%) ⬇️
src/agent/coverage/src/test.rs 85.71% <0.00%> (-14.29%) ⬇️
src/agent/onefuzz/src/monitor.rs 67.12% <0.00%> (-13.70%) ⬇️
src/agent/onefuzz/src/machine_id.rs 51.72% <0.00%> (-5.12%) ⬇️
src/agent/onefuzz/src/expand.rs 62.97% <0.00%> (-3.52%) ⬇️
src/agent/onefuzz/src/sanitizer.rs 72.22% <0.00%> (-0.39%) ⬇️
src/agent/onefuzz-agent/src/worker/tests.rs 99.07% <0.00%> (-0.14%) ⬇️
src/agent/onefuzz/src/asan.rs 0.00% <0.00%> (ø)
... and 141 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tevoinea tevoinea merged commit 76cde40 into microsoft:main Oct 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants