Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Improve AppInsights setup #2597

Merged
merged 6 commits into from
Nov 3, 2022
Merged

Improve AppInsights setup #2597

merged 6 commits into from
Nov 3, 2022

Conversation

Porges
Copy link
Member

@Porges Porges commented Nov 2, 2022

Switch to using the package provided by Azure Functions to set up Application Insights.

Using the provided setup method AddApplicationInsightsTelemetry will configure the dependency collector by default as well as set up some other things that we haven’t done manually, including application version, which would be very useful.

This also means that operation_Id is populated more consistently which permits joining traces or dependencies on the requests table.

This also means that the end-to-end data in AI is now correct, so the chart works:
MicrosoftTeams-image

@Porges Porges force-pushed the improve-app-insights branch from bd9500d to 97c8647 Compare November 2, 2022 21:41
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #2597 (22cb201) into main (22cb201) will not change coverage.
The diff coverage is n/a.

❗ Current head 22cb201 differs from pull request most recent head 74f51aa. Consider uploading reports for the commit 74f51aa to get more accurate results

@@           Coverage Diff           @@
##             main    #2597   +/-   ##
=======================================
  Coverage   29.85%   29.85%           
=======================================
  Files         289      289           
  Lines       35809    35809           
=======================================
  Hits        10692    10692           
  Misses      25117    25117           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Porges Porges marked this pull request as ready for review November 3, 2022 00:53
@Porges Porges force-pushed the improve-app-insights branch from 6a8a95d to 74f51aa Compare November 3, 2022 00:58
@Porges Porges enabled auto-merge (squash) November 3, 2022 01:00
@Porges Porges merged commit f1f6400 into main Nov 3, 2022
@Porges Porges deleted the improve-app-insights branch November 3, 2022 01:10
@Porges Porges mentioned this pull request Nov 3, 2022
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Nov 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants