This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Use broker or browser login instead of device flow #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2612 +/- ##
==========================================
- Coverage 30.37% 29.37% -1.01%
==========================================
Files 255 290 +35
Lines 29441 35597 +6156
==========================================
+ Hits 8943 10456 +1513
- Misses 20498 25141 +4643
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Porges
force-pushed
the
browser-auth
branch
2 times, most recently
from
285bf25 to
8486fdf
Compare
Porges
changed the title
|
Verified; ready for review. |
mgreisen
approved these changes
Nov 11, 2022
Porges
force-pushed
the
browser-auth
branch
2 times, most recently
from
779aa6d to
9979886
Compare
chkeita
approved these changes
Nov 14, 2022
stishkin
approved these changes
Nov 14, 2022
Porges
added a commit
that referenced
this pull request
Nov 14, 2022
Update CLI to attempt broker or browser-based authentication first; if you `Ctrl-C` to cancel it, you can fall back to device code login. Also updated the MSAL dependency to latest version and pass `allow_broker=True` which will allow the use of Web Account Manager (WAM), if it is available. Using browser auth requires the `http://localhost` redirect URI, and using the broker requires a special custom URI including the app ID (see code).
Merged
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CLI to attempt broker or browser-based authentication first; if you
Ctrl-Cto cancel it, you can fall back to device code login.Also updated the MSAL dependency to latest version and pass
allow_broker=Truewhich will allow the use of Web Account Manager (WAM), if it is available.Using browser auth requires the
http://localhostredirect URI, and using the broker requires a special custom URI including the app ID (see code).