Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Bug fixes related to the unmanaged nodes #2632

Merged
merged 6 commits into from
Nov 17, 2022
Merged

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Nov 16, 2022

  • fix the token request in the client
  • adding a managed field to the agentConfig
  • fix typo in the appId claim type
  • fix typo in the UnmanagedNode claim value
  • fix query PoolOperation.GetByClientId

related to #2521

- fix the token request in the client
- adding a is_unmnaged field to the agentConfig
- fix typo in the appId claim type
- fix typo in the UnmanagedNode claim value
- fix query PoolOperation.GetByClientId
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #2632 (c4cc236) into main (07befc5) will decrease coverage by 0.00%.
The diff coverage is 16.00%.

@@            Coverage Diff             @@
##             main    #2632      +/-   ##
==========================================
- Coverage   29.37%   29.36%   -0.01%     
==========================================
  Files         290      290              
  Lines       35596    35607      +11     
==========================================
+ Hits        10455    10457       +2     
- Misses      25141    25150       +9     
Impacted Files Coverage Δ
src/ApiService/ApiService/UserCredentials.cs 8.82% <0.00%> (ø)
...ice/ApiService/onefuzzlib/EndpointAuthorization.cs 21.77% <0.00%> (-0.36%) ⬇️
src/ApiService/ApiService/onefuzzlib/Extension.cs 0.00% <0.00%> (ø)
...ApiService/ApiService/onefuzzlib/PoolOperations.cs 40.00% <0.00%> (ø)
src/agent/onefuzz-agent/src/config.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-agent/src/main.rs 0.47% <0.00%> (ø)
src/agent/onefuzz/src/auth.rs 30.53% <ø> (+0.18%) ⬆️
src/ApiService/ApiService/Functions/Pool.cs 92.63% <100.00%> (+0.07%) ⬆️
src/ApiService/ApiService/OneFuzzTypes/Model.cs 72.05% <100.00%> (+0.03%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

chkeita and others added 3 commits November 17, 2022 11:01
Co-authored-by: Teo Voinea <58236992+tevoinea@users.noreply.github.com>
@chkeita chkeita enabled auto-merge (squash) November 17, 2022 20:43
@chkeita chkeita merged commit 1f46388 into microsoft:main Nov 17, 2022
@nharper285 nharper285 mentioned this pull request Nov 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants