Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Improve logging around notification failures #2653

Merged

Conversation

tevoinea
Copy link
Member

Summary of the Pull Request

What is this about?

  • Clean up QueueFileChanges to use the log that's passed in via DI
  • Include additional notification info when logging failures in Ado

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Merging #2653 (efb1f62) into main (e0634a3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2653      +/-   ##
==========================================
- Coverage   29.26%   29.26%   -0.01%     
==========================================
  Files         290      290              
  Lines       35685    35686       +1     
==========================================
  Hits        10444    10444              
- Misses      25241    25242       +1     
Impacted Files Coverage Δ
...piService/ApiService/Functions/QueueFileChanges.cs 15.62% <0.00%> (-0.25%) ⬇️
...Service/ApiService/onefuzzlib/notifications/Ado.cs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tevoinea tevoinea merged commit 95abeea into microsoft:main Nov 25, 2022
@nharper285 nharper285 mentioned this pull request Nov 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants