Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Support Contains Words in WIQL #2686

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

tevoinea
Copy link
Member

@tevoinea tevoinea commented Dec 9, 2022

Summary of the Pull Request

What is this about?

Fixes The specified operator cannot be used with long-text fields. error we've been seeing lately when attempting to create ADO work items.

Info on Pull Request

The = operator is not support on long-text fields. The ADO API tells us which operators are supported for a particular field. The particular field in which we saw this error does support the Contains Words operator. Fall back to Contains Words if = is not supported.

What does this include?

Validation Steps Performed

  • Reproduced the error we were observing in local dev API call to ADO
  • The error doesn't happen anymore after this PR

@codecov-commenter
Copy link

Codecov Report

Merging #2686 (d5d707a) into main (f48546f) will decrease coverage by 4.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2686      +/-   ##
==========================================
- Coverage   29.38%   25.36%   -4.03%     
==========================================
  Files         291      123     -168     
  Lines       36048    12855   -23193     
==========================================
- Hits        10594     3261    -7333     
+ Misses      25454     9594   -15860     
Impacted Files Coverage Δ
src/ApiService/ApiService/Log.cs 7.72% <0.00%> (-0.10%) ⬇️
src/ApiService/ApiService/OneFuzzTypes/Enums.cs 32.39% <ø> (ø)
...Service/ApiService/onefuzzlib/notifications/Ado.cs 0.00% <0.00%> (ø)
src/agent/win-util/src/jobs.rs
...gent/input-tester/src/test_result/vcpp_debugger.rs
src/agent/onefuzz/src/uploader.rs
src/agent/onefuzz-task/src/local/test_input.rs
src/agent/onefuzz-task/src/main.rs
src/agent/debugger/src/module.rs
...nt/onefuzz-task/src/tasks/report/dotnet/generic.rs
... and 161 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tevoinea tevoinea enabled auto-merge (squash) December 9, 2022 16:01
@tevoinea tevoinea merged commit 2a44900 into microsoft:main Dec 9, 2022
@mgreisen mgreisen mentioned this pull request Dec 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants