Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Bug fixes and documentation #2694

Merged
merged 29 commits into from
Dec 16, 2022

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Dec 13, 2022

Summary of the Pull Request

What is this about?

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Merging #2694 (e31a405) into main (ff923d2) will decrease coverage by 3.24%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main    #2694      +/-   ##
==========================================
- Coverage   28.64%   25.39%   -3.25%     
==========================================
  Files         308      123     -185     
  Lines       37650    12889   -24761     
==========================================
- Hits        10783     3273    -7510     
+ Misses      26867     9616   -17251     
Impacted Files Coverage Δ
src/ApiService/ApiService/ServiceConfiguration.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/onefuzzlib/Creds.cs 0.00% <0.00%> (ø)
...ApiService/ApiService/onefuzzlib/NodeOperations.cs 23.78% <33.33%> (+0.07%) ⬆️
...iService/ApiService/Functions/AgentRegistration.cs 85.59% <100.00%> (+0.24%) ⬆️
src/ApiService/ApiService/OneFuzzTypes/Model.cs 71.11% <100.00%> (+0.04%) ⬆️
src/agent/onefuzz-agent/src/config.rs
src/agent/onefuzz-agent/src/main.rs
src/agent/onefuzz/src/auth.rs
...rc/agent/onefuzz-task/src/tasks/coverage/dotnet.rs
...gent/onefuzz-task/src/tasks/report/crash_report.rs
... and 180 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chkeita chkeita force-pushed the unmanaged_nodes/registration_script branch from 62a0921 to 8e937bc Compare December 13, 2022 06:33
@chkeita chkeita force-pushed the unmanaged_nodes/registration_script branch from 8e937bc to ef21440 Compare December 13, 2022 06:40
@chkeita chkeita force-pushed the unmanaged_nodes/registration_script branch from 8c6735f to f024164 Compare December 13, 2022 19:37
@chkeita chkeita marked this pull request as ready for review December 13, 2022 19:38
@chkeita chkeita requested review from Porges and tevoinea December 13, 2022 19:38
Copy link
Member

@Porges Porges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly capitalization/punctuation changes to docs

docs/unmnaged-nodes.md Outdated Show resolved Hide resolved
docs/unmnaged-nodes.md Outdated Show resolved Hide resolved
docs/unmnaged-nodes.md Outdated Show resolved Hide resolved
docs/unmnaged-nodes.md Outdated Show resolved Hide resolved
docs/unmnaged-nodes.md Outdated Show resolved Hide resolved
docs/unmnaged-nodes.md Outdated Show resolved Hide resolved
docs/unmnaged-nodes.md Outdated Show resolved Hide resolved
docs/unmnaged-nodes.md Outdated Show resolved Hide resolved
docs/unmnaged-nodes.md Outdated Show resolved Hide resolved
docs/unmnaged-nodes.md Outdated Show resolved Hide resolved
@chkeita chkeita requested a review from Porges December 14, 2022 00:59
@chkeita chkeita merged commit 0fb8bc4 into microsoft:main Dec 16, 2022
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jan 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants