This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Trim output from monitored process before printing #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrChat
force-pushed
the
user/jusmoore/stream_newlines
branch
from
82b808e to
d09d4b7
Compare
tevoinea
approved these changes
Jan 30, 2023
Porges
approved these changes
Feb 1, 2023
Porges
force-pushed
the
user/jusmoore/stream_newlines
branch
from
d09d4b7 to
18a5023
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This simply trims whitespace from monitored streams before printing their output.
This fixes the common case where two newlines are printed for every line logged from a child process.
The reason this occurred in the first place is because
read_untilwill read a line up to (and including) the delimiter and/or EOF.