Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix coverage example build #2831

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

ranweiler
Copy link
Member

The coverage crate does not build on its own unless the namedpipeapi feature from winapi is enabled.

In the larger OneFuzz workspace, this feature is enabled for winapi elsewhere, which is why the build generally is not broken.

A note: winapi hasn't had a commit since November 2021.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #2831 (c93e175) into main (0bc22a8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2831   +/-   ##
=======================================
  Coverage   29.93%   29.93%           
=======================================
  Files         324      324           
  Lines       38991    38991           
=======================================
  Hits        11671    11671           
  Misses      27320    27320           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tevoinea
Copy link
Member

A note: winapi hasn't had a commit since November 2021.

Do you think it'd be worth looking into moving to windows?

@ranweiler
Copy link
Member Author

A note: winapi hasn't had a commit since November 2021.

Do you think it'd be worth looking into moving to windows?

Definitely. It's not urgent, but I'll need to do a port of the debugger backend eventually.

@ranweiler ranweiler merged commit 0c58a59 into microsoft:main Feb 14, 2023
@ranweiler ranweiler deleted the fix-coverage-example-build branch February 14, 2023 15:54
@mgreisen mgreisen mentioned this pull request Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants