This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Defer coverage breakpoints #2832
Merged
ranweiler
merged 17 commits into
microsoft:main
from
ranweiler:defer-coverage-breakpoints
Feb 14, 2023
Merged
Defer coverage breakpoints #2832
ranweiler
merged 17 commits into
microsoft:main
from
ranweiler:defer-coverage-breakpoints
Feb 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranweiler
commented
Feb 14, 2023
ranweiler
commented
Feb 14, 2023
ranweiler
commented
Feb 14, 2023
ranweiler
commented
Feb 14, 2023
ranweiler
commented
Feb 14, 2023
ranweiler
commented
Feb 14, 2023
ranweiler
commented
Feb 14, 2023
Codecov Report
@@ Coverage Diff @@
## main #2832 +/- ##
==========================================
- Coverage 29.93% 29.87% -0.06%
==========================================
Files 324 324
Lines 38994 39062 +68
==========================================
Hits 11671 11671
- Misses 27323 27391 +68
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ranweiler
commented
Feb 14, 2023
chkeita
approved these changes
Feb 14, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each loaded module, defer setting coverage breakpoints until exit from certain known initialization functions (when present). Crucially, this lets us avoid breaking Address Sanitizer interceptor initialization, which will otherwise divergently fail execution by raising its own debug break exception.
With this PR, neither OneFuzz itself nor locally-debugging end users will need to use an allowlist to exclude ASan-intercepted functions from coverage recording.
This PR also fixes a bug in breakpoint setting, which would would prevent setting breakpoints whose offset collided with any other breakpoint's offset (ignoring base module). This would manifest in false negative coverage counts for colliding breakpoints.