This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Config Refactor Part 2 - Change Opt Param Names & Set File Expiry #2835
Merged
nharper285
merged 19 commits into
microsoft:main
from
nharper285:user/noharper/config-refactor-part-2.2
Feb 18, 2023
Merged
Config Refactor Part 2 - Change Opt Param Names & Set File Expiry #2835
nharper285
merged 19 commits into
microsoft:main
from
nharper285:user/noharper/config-refactor-part-2.2
Feb 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2835 +/- ##
==========================================
+ Coverage 28.08% 28.15% +0.07%
==========================================
Files 302 171 -131
Lines 35651 20912 -14739
==========================================
- Hits 10012 5888 -4124
+ Misses 25639 15024 -10615
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chkeita
approved these changes
Feb 14, 2023
mgreisen
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ub.com/nharper285/onefuzz into user/noharper/config-refactor-part-2.2
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
This is the final step of #2773. In this PR, we change the names of the optional
config
params. This will cause a breaking change for the CLI.We have also added an expiry the local config value cache. Now, if a file is older than 24hrs, we delete and reset.
NOTE: For SP use, users will need to update their
--client_id
flag to--override_client_id
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?