Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Config Refactor Part 2 - Change Opt Param Names & Set File Expiry #2835

Merged

Conversation

nharper285
Copy link
Contributor

@nharper285 nharper285 commented Feb 14, 2023

Summary of the Pull Request

What is this about?
This is the final step of #2773. In this PR, we change the names of the optional config params. This will cause a breaking change for the CLI.
We have also added an expiry the local config value cache. Now, if a file is older than 24hrs, we delete and reset.

NOTE: For SP use, users will need to update their --client_id flag to --override_client_id

PR Checklist

  • Applies to work item: CLI Config Refactor #2773
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #2835 (7303803) into main (5061a3d) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2835      +/-   ##
==========================================
+ Coverage   28.08%   28.15%   +0.07%     
==========================================
  Files         302      171     -131     
  Lines       35651    20912   -14739     
==========================================
- Hits        10012     5888    -4124     
+ Misses      25639    15024   -10615     
Impacted Files Coverage Δ
src/agent/onefuzz/src/env.rs 0.00% <0.00%> (-83.34%) ⬇️
src/agent/onefuzz/src/libfuzzer.rs 11.97% <0.00%> (-57.47%) ⬇️
src/agent/onefuzz/src/memory.rs 0.00% <0.00%> (-25.00%) ⬇️
src/agent/onefuzz/src/monitor.rs 67.12% <0.00%> (-13.70%) ⬇️
src/agent/onefuzz/src/machine_id.rs 14.67% <0.00%> (-5.84%) ⬇️
src/agent/onefuzz/src/fs.rs 53.57% <0.00%> (-1.01%) ⬇️
src/agent/onefuzz/src/expand.rs 81.75% <0.00%> (-0.54%) ⬇️
src/agent/onefuzz/src/sanitizer.rs 71.23% <0.00%> (-0.39%) ⬇️
src/agent/onefuzz-agent/src/worker/tests.rs 99.07% <0.00%> (-0.14%) ⬇️
src/agent/onefuzz/src/asan.rs 0.00% <0.00%> (ø)
... and 141 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mgreisen mgreisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nharper285 nharper285 merged commit 1ac3fd4 into microsoft:main Feb 18, 2023
@mgreisen mgreisen mentioned this pull request Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants