Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Report extension errors #2846

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Report extension errors #2846

merged 2 commits into from
Feb 16, 2023

Conversation

Porges
Copy link
Member

@Porges Porges commented Feb 16, 2023

Closes #2804.


Old failure message:

failed to launch extension

New failure message:

failed to launch extension(s): Errors for extension 'CustomScriptExtension':
:Error: ProvisioningState/failed/3 (Provisioning failed) - Failed to download all specified files. Exiting. Error Message: The remote server returned an error: (400) Bad Request.

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #2846 (0eca956) into main (e0e6981) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2846      +/-   ##
==========================================
- Coverage   28.12%   28.11%   -0.02%     
==========================================
  Files         302      302              
  Lines       35574    35590      +16     
==========================================
  Hits        10006    10006              
- Misses      25568    25584      +16     
Impacted Files Coverage Δ
...c/ApiService/ApiService/onefuzzlib/VmOperations.cs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Porges Porges requested a review from tevoinea February 16, 2023 02:16
@Porges Porges merged commit 124f50d into main Feb 16, 2023
@Porges Porges deleted the report-extension-errors branch February 16, 2023 03:05
chkeita pushed a commit to chkeita/onefuzz that referenced this pull request Feb 16, 2023
Old failure message:
```
failed to launch extension
```

New failure message:

```
failed to launch extension(s): Errors for extension 'CustomScriptExtension':
:Error: ProvisioningState/failed/3 (Provisioning failed) - Failed to download all specified files. Exiting. Error Message: The remote server returned an error: (400) Bad Request.
```
chkeita added a commit that referenced this pull request Feb 23, 2023
* adding extra container to tasks

* setup expand

* build fix

* generate docs

* build fix

* build fix

* build fix

* format

* format

* build fix

* fix extra container references

* format

* Update "Needs Triage" label to the one we use. (#2845)

* Report extension errors (#2846)

Old failure message:
```
failed to launch extension
```

New failure message:

```
failed to launch extension(s): Errors for extension 'CustomScriptExtension':
:Error: ProvisioningState/failed/3 (Provisioning failed) - Failed to download all specified files. Exiting. Error Message: The remote server returned an error: (400) Bad Request.
```

* Sematically validate notification configs (#2850)

* Add new command

* Update remaining jinja templates and references to use scriban

* Add ado template validation

* Validate ado and github templates

* Remove unnecessary function

* Update src/ApiService/ApiService/OneFuzzTypes/Model.cs

Co-authored-by: Cheick Keita <kcheick@gmail.com>

---------

Co-authored-by: Cheick Keita <kcheick@gmail.com>

* adding extra container to integration tests

* adding doc

* update tests

* format

* build and clippy fix

* Update src/agent/onefuzz-task/src/tasks/report/generic.rs

Co-authored-by: Teo Voinea <58236992+tevoinea@users.noreply.github.com>

---------

Co-authored-by: Marc Greisen <mgreisen@microsoft.com>
Co-authored-by: George Pollard <gpollard@microsoft.com>
Co-authored-by: Teo Voinea <58236992+tevoinea@users.noreply.github.com>
@mgreisen mgreisen mentioned this pull request Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log extension failure reason when extension fails to launch
3 participants