This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Bump clap in proxy to 4.0
#2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2855 +/- ##
==========================================
+ Coverage 28.08% 28.09% +0.01%
==========================================
Files 302 302
Lines 35653 35629 -24
==========================================
- Hits 10012 10011 -1
+ Misses 25641 25618 -23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chkeita
approved these changes
Feb 17, 2023
Porges
added a commit
that referenced
this pull request
Feb 19, 2023
A Friday afternoon jaunt. To be merged after #2855; does the remaining work to close #2277 (and closes off some things that Dependabot was trying to upgrade). Tested by manually running the commands; we don't have good coverage for this kind of stuff. OTOH, most of these commands are for the experimental local fuzzing mode, which is not fully supported yet. I did specifically test the `onefuzz-task managed` command which is the one used in production. ## Details - Bump `clap` to 4.1.6 - Remove `structopt` as this is subsumed by clap now - Bump `envlogger` to 0.10 (removes problematic dependency) - Set `default-features=false` on `proc-maps` (removes a feature which is only needed to support FreeBSD), and bump it to 0.3 The main changes migrating `clap` are: - `value_t!` is gone; now use `matches.get_one::<T>`. If `T` is not `String` then a parser must have been registered on the `Arg` when it was created, with `arg.value_parser(value_parser!(T))`. - `Command::with_name` and `Arg::with_name` are now called `new`. - `Command` and `Subcommand` were unified, and `App` is removed. - `arg.takes_value(true)` is gone; it is the default. For flags use `arg.action(ArgAction::SetTrue)` and then retrieve the flag value with `matches.get_flag`. This code would be simplified a lot by using the `clap::Parser` on structs, but that requires reworking the code significantly as we cannot dynamically add/remove arguments the way that this is currently done. ## Also found Found one bug while manually testing the `onefuzz-task local` commands; see comment below.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required work for #2277.