This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Fix onefuzz repro
bug - Remove managed identity from CustomScriptExtension
#2920
Merged
nharper285
merged 12 commits into
microsoft:main
from
nharper285:user/noharper/repro-fix
Mar 10, 2023
Merged
Fix onefuzz repro
bug - Remove managed identity from CustomScriptExtension
#2920
nharper285
merged 12 commits into
microsoft:main
from
nharper285:user/noharper/repro-fix
Mar 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…85/onefuzz into user/noharper/repro-fix
AdamL-Microsoft
approved these changes
Mar 9, 2023
stishkin
approved these changes
Mar 9, 2023
Porges
approved these changes
Mar 9, 2023
chkeita
approved these changes
Mar 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #2920 +/- ##
=======================================
Coverage 28.84% 28.84%
=======================================
Files 302 302
Lines 35895 35895
=======================================
Hits 10353 10353
Misses 25542 25542
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mgreisen
approved these changes
Mar 9, 2023
tevoinea
approved these changes
Mar 10, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
The
CustomScriptExtension
began failing due to the empty managed identity that's added to its configuration. Despite having this configuration for some time, the extension began failing abut three weeks ago (potentially due to an internal change).This PR removes the managed identity from the extension config.
PR Checklist
CustomScriptExtension
fails to provision duringrepro
startup. #2919Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?