Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix onefuzz repro bug - Remove managed identity from CustomScriptExtension #2920

Merged
merged 12 commits into from
Mar 10, 2023

Conversation

nharper285
Copy link
Contributor

Summary of the Pull Request

What is this about?
The CustomScriptExtension began failing due to the empty managed identity that's added to its configuration. Despite having this configuration for some time, the extension began failing abut three weeks ago (potentially due to an internal change).

This PR removes the managed identity from the extension config.

PR Checklist

  • Applies to work item: CustomScriptExtension fails to provision during repro startup.  #2919
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

src/ApiService/ApiService/onefuzzlib/Extension.cs Outdated Show resolved Hide resolved
@mgreisen
Copy link
Contributor

mgreisen commented Mar 9, 2023

            ProtectedSettings = new BinaryData(managedIdentity)

don't we need to do this here as well?


Refers to: src/ApiService/ApiService/onefuzzlib/Extension.cs:318 in bb16de8. [](commit_id = bb16de8, deletion_comment = False)

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #2920 (ab3a4fc) into main (f00248f) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2920   +/-   ##
=======================================
  Coverage   28.84%   28.84%           
=======================================
  Files         302      302           
  Lines       35895    35895           
=======================================
  Hits        10353    10353           
  Misses      25542    25542           
Impacted Files Coverage Δ
src/ApiService/ApiService/onefuzzlib/Extension.cs 0.00% <0.00%> (ø)
...piService/ApiService/onefuzzlib/ReproOperations.cs 10.81% <ø> (ø)
...c/ApiService/ApiService/onefuzzlib/VmOperations.cs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nharper285 nharper285 merged commit a374939 into microsoft:main Mar 10, 2023
@mgreisen mgreisen mentioned this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants