Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Better logging of failure in the task_logger #2940

Merged
merged 7 commits into from
Apr 6, 2023
Merged

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Mar 23, 2023

Summary of the Pull Request

Add better logging when the task_logger fails

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #2940 (d5df814) into main (f62fe0c) will decrease coverage by 0.09%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #2940      +/-   ##
==========================================
- Coverage   29.10%   29.02%   -0.09%     
==========================================
  Files         304      304              
  Lines       36341    36300      -41     
==========================================
- Hits        10576    10535      -41     
  Misses      25765    25765              
Impacted Files Coverage Δ
src/agent/onefuzz-agent/src/validations.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/tasks/task_logger.rs 44.70% <33.33%> (-0.03%) ⬇️

... and 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chkeita chkeita changed the title [WIP] task_logger failure Better logging of failure in the task_logger Apr 5, 2023
@chkeita chkeita linked an issue Apr 5, 2023 that may be closed by this pull request
@chkeita chkeita marked this pull request as ready for review April 5, 2023 16:49
@chkeita chkeita requested review from Porges and tevoinea April 5, 2023 17:07
@chkeita chkeita enabled auto-merge (squash) April 6, 2023 00:27
@chkeita chkeita merged commit d27d815 into microsoft:main Apr 6, 2023
AdamL-Microsoft added a commit that referenced this pull request Apr 6, 2023
This was referenced Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants