This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Use minimized stack for crash site if no ASAN logs available #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2962 +/- ##
==========================================
+ Coverage 29.07% 29.10% +0.02%
==========================================
Files 304 304
Lines 36335 36337 +2
==========================================
+ Hits 10566 10577 +11
+ Misses 25769 25760 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Porges
force-pushed
the
use-minimized-stack-for-crash-site
branch
from
109db37 to
a2c5f70
Compare
Porges
commented
Apr 4, 2023
tevoinea
approved these changes
Apr 4, 2023
* Add new command * Update remaining jinja templates and references to use scriban * Do not enforce that key exists in dictionary when doing strict validation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #841.
If all we have is a call stack, use the top of the "minimized stack" as the crash site, not the top of the full stack.
This only happens if we don't have ASAN logs available for the crash.