This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Remove Additional config params - require on each request
#3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'user/noharper/cli-cache-fix' of https://github.com/nharper285/onefuzz into user/noharper/cli-cache-fix
Codecov Report
@@ Coverage Diff @@
## main #3000 +/- ##
=======================================
Coverage 29.02% 29.02%
=======================================
Files 304 304
Lines 36326 36326
=======================================
Hits 10545 10545
Misses 25781 25781 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…per285/onefuzz into user/noharper/cli-cache-fix
mgreisen
approved these changes
Apr 7, 2023
stishkin
suggested changes
Apr 7, 2023
For that we'd probably want a global file lock like this https://github.com/symonsoft/ilock |
|
It looks like ilock is designed for a single process. |
nharper285
changed the title
config params - require on each request
stishkin
reviewed
Apr 10, 2023
mgreisen
reviewed
Apr 10, 2023
stishkin
approved these changes
Apr 10, 2023
…harper285/onefuzz into user/noharper/cli-cache-fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Resolve CLI config cache race condition. Remove caching of config params. Only store endpoint and require params per CLI command.
PR Checklist
configcache read causes race condition #2999Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?